-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ERM-3332, Add documents filter to agreement line search #704
Conversation
License CLA Stuck? (Developer should make sure that it is really stuck before clicking) |
Jest Unit Test Results 1 files ± 0 42 suites +5 1m 20s ⏱️ +10s Results for commit 71582dd. ± Comparison against base commit dc404b6. This pull request removes 6 and adds 61 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
Allow for default and custom labelling of DocumentFilters. Also added centralised "core documents" and "supplementary documents" labels as we use those terms in multiple modules ERM-3332
Ensure that we're passing down filterName so that supplementary vs core vs docs can all be set up in the generic component
Deprecated atTypeValues (but still in place anyway. Use categoryValues instead
No longer relying on "supplementary docs" to be the name of the field. Instead have `ifCategory` decide whether or not to render the field, then use the passed filterName to work out whether to diplsay value as TextField or Select
…ing for the heirachy
…hat both tests can make use. Improved DocumentForm test
|
ERM-3332