Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ERM-3332, Add documents filter to agreement line search #704

Merged
merged 21 commits into from
Oct 29, 2024

Conversation

MonireRasouli
Copy link
Contributor

@MonireRasouli MonireRasouli commented Oct 21, 2024

Copy link

License CLA Stuck? (Developer should make sure that it is really stuck before clicking)

Copy link

github-actions bot commented Oct 21, 2024

Jest Unit Test Results

  1 files  ± 0   42 suites  +5   1m 20s ⏱️ +10s
318 tests +55  318 ✅ +55  0 💤 ±0  0 ❌ ±0 
319 runs  +55  319 ✅ +55  0 💤 ±0  0 ❌ ±0 

Results for commit 71582dd. ± Comparison against base commit dc404b6.

This pull request removes 6 and adds 61 tests. Note that renamed tests count towards both.
InternalContactSelectionDisplay correct number of internal contact role options rendered ‑ InternalContactSelectionDisplay correct number of internal contact role options rendered
InternalContactSelectionDisplay renders Select an internal contact button ‑ InternalContactSelectionDisplay renders Select an internal contact button
InternalContactSelectionDisplay renders intenal contact option(s) ‑ InternalContactSelectionDisplay renders intenal contact option(s)
OrganizationSelectionDisplay The right number of options exist ‑ OrganizationSelectionDisplay The right number of options exist
OrganizationSelectionDisplay renders Select an organization button ‑ OrganizationSelectionDisplay renders Select an organization button
OrganizationSelectionDisplay renders organization name(s) ‑ OrganizationSelectionDisplay renders organization name(s)
DocumentFilter ActiveFilter tests with active filters renders DocumentFilterForm component ‑ DocumentFilter ActiveFilter tests with active filters renders DocumentFilterForm component
DocumentFilter ActiveFilter tests with active filters renders expected filters text ‑ DocumentFilter ActiveFilter tests with active filters renders expected filters text
DocumentFilter ActiveFilter tests with active filters renders the document filters accordion ‑ DocumentFilter ActiveFilter tests with active filters renders the document filters accordion
DocumentFilter ActiveFilter tests with active filters testing parsedFilterData parsed filter data is as expected ‑ DocumentFilter ActiveFilter tests with active filters testing parsedFilterData parsed filter data is as expected
DocumentFilter ActiveFilter tests with multiple active filters renders DocumentFilterForm component ‑ DocumentFilter ActiveFilter tests with multiple active filters renders DocumentFilterForm component
DocumentFilter ActiveFilter tests with multiple active filters renders expected filters text ‑ DocumentFilter ActiveFilter tests with multiple active filters renders expected filters text
DocumentFilter ActiveFilter tests with multiple active filters renders the document filters accordion ‑ DocumentFilter ActiveFilter tests with multiple active filters renders the document filters accordion
DocumentFilter ActiveFilter tests with multiple active filters testing parsedFilterData parsed filter data is as expected ‑ DocumentFilter ActiveFilter tests with multiple active filters testing parsedFilterData parsed filter data is as expected
DocumentFilter ActiveFilter tests without active filters renders DocumentFilterForm component ‑ DocumentFilter ActiveFilter tests without active filters renders DocumentFilterForm component
DocumentFilter ActiveFilter tests without active filters renders expected filters text ‑ DocumentFilter ActiveFilter tests without active filters renders expected filters text
…

♻️ This comment has been updated with latest results.

EthanFreestone and others added 7 commits October 21, 2024 15:02
Allow for default and custom labelling of DocumentFilters. Also added centralised "core documents" and "supplementary documents" labels as we use those terms in multiple modules

ERM-3332
Ensure that we're passing down filterName so that supplementary vs core vs docs can all be set up in the generic component
Deprecated atTypeValues (but still in place anyway. Use categoryValues instead
 No longer relying on "supplementary docs" to be the name of the field. Instead have `ifCategory` decide whether or not to render the field, then use the passed filterName to work out whether to diplsay value as TextField or Select
@MonireRasouli MonireRasouli changed the title Erm 3332 ERM-3332, Add documents filter to agreement line search Oct 22, 2024
@MonireRasouli MonireRasouli marked this pull request as ready for review October 23, 2024 13:02
Copy link

@EthanFreestone EthanFreestone merged commit 7879c28 into master Oct 29, 2024
15 checks passed
@EthanFreestone EthanFreestone deleted the ERM-3332 branch October 29, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants